On Thu, Feb 05, 2004 at 09:58:18AM -0800, John Cherry wrote:
>...
> The nit warnings that sprung up in the defconfig builds are...
>...
> drivers/usb/input/hid-input.c: In function `hidinput_hid_event':
> drivers/usb/input/hid-input.c:436: warning: suggest parentheses around
> && within ||
>...
This one's easy to fix:
---
25-akpm/drivers/usb/input/hid-input.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/usb/input/hid-input.c~input-2wheel-mouse-fix-fix drivers/usb/input/hid-input.c
--- 25/drivers/usb/input/hid-input.c~input-2wheel-mouse-fix-fix Thu Feb 5 15:29:14 2004
+++ 25-akpm/drivers/usb/input/hid-input.c Thu Feb 5 15:29:14 2004
@@ -433,7 +433,7 @@ void hidinput_hid_event(struct hid_devic
input_regs(input, regs);
if (((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_EXTRA) && (usage->code == BTN_EXTRA))
- || (hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK)) {
+ || ((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK))) {
if (value)
hid->quirks |= HID_QUIRK_2WHEEL_MOUSE_HACK_ON;
else
_